granthenke commented on a change in pull request #4276:
URL: https://github.com/apache/nifi/pull/4276#discussion_r428631210
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java
##########
@@ -176,13 +176,25 @@ protected void flushKuduSession(final KuduSession
kuduSession, boolean close, fi
}
}
- protected KerberosUser loginKerberosKeytabUser(final String principal,
final String keytab) throws LoginException {
- final KerberosUser kerberosUser = new KerberosKeytabUser(principal,
keytab);
+ protected KerberosUser loginKerberosKeytabUser(final String principal,
final String keytab, ProcessContext context) throws LoginException {
+ final KerberosUser kerberosUser = new KerberosKeytabUser(principal,
keytab) {
+ @Override
+ public synchronized boolean checkTGTAndRelogin() throws
LoginException {
+ boolean didRelogin = super.checkTGTAndRelogin();
+
+ if (didRelogin) {
+ final KerberosAction<KuduClient> kerberosAction = new
KerberosAction<>(this, () -> buildClient(context), getLogger());
+ AbstractKuduProcessor.this.kuduClient =
kerberosAction.execute();
+ }
+
+ return didRelogin;
+ }
+ };
kerberosUser.login();
return kerberosUser;
}
- protected KerberosUser loginKerberosPasswordUser(final String principal,
final String password) throws LoginException {
+ protected KerberosUser loginKerberosPasswordUser(final String principal,
final String password, ProcessContext context) throws LoginException {
Review comment:
It looks used in `buildClient(context)` below.
##########
File path:
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/AbstractKuduProcessor.java
##########
@@ -176,14 +176,38 @@ protected void flushKuduSession(final KuduSession
kuduSession, boolean close, fi
}
}
- protected KerberosUser loginKerberosKeytabUser(final String principal,
final String keytab) throws LoginException {
- final KerberosUser kerberosUser = new KerberosKeytabUser(principal,
keytab);
+ protected KerberosUser loginKerberosKeytabUser(final String principal,
final String keytab, ProcessContext context) throws LoginException {
+ final KerberosUser kerberosUser = new KerberosKeytabUser(principal,
keytab) {
+ @Override
+ public synchronized boolean checkTGTAndRelogin() throws
LoginException {
+ boolean didRelogin = super.checkTGTAndRelogin();
+
+ if (didRelogin) {
+ final KerberosAction<KuduClient> kerberosAction = new
KerberosAction<>(this, () -> buildClient(context), getLogger());
+ AbstractKuduProcessor.this.kuduClient =
kerberosAction.execute();
Review comment:
Should this call `close()` on the old client before creating a new one?
Is that safe to do in a multithreaded context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
