arpadboda commented on a change in pull request #794:
URL: https://github.com/apache/nifi-minifi-cpp/pull/794#discussion_r430355694
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -82,10 +82,33 @@ core::Property PublishKafka::TargetBatchPayloadSize(
core::PropertyBuilder::createProperty("Target Batch Payload
Size")->withDescription("The target total payload size for a batch. 0 B means
unlimited (Batch Size is still applied).")
->isRequired(false)->withDefaultValue<core::DataSizeValue>("512
KB")->build());
core::Property PublishKafka::AttributeNameRegex("Attributes to Send as
Headers", "Any attribute whose name matches the regex will be added to the
Kafka messages as a Header", "");
-core::Property PublishKafka::QueueBufferMaxTime("Queue Buffering Max Time",
"Delay to wait for messages in the producer queue to accumulate before
constructing message batches", "");
-core::Property PublishKafka::QueueBufferMaxSize("Queue Max Buffer Size",
"Maximum total message size sum allowed on the producer queue", "");
-core::Property PublishKafka::QueueBufferMaxMessage("Queue Max Message",
"Maximum number of messages allowed on the producer queue", "");
-core::Property PublishKafka::CompressCodec("Compress Codec", "compression
codec to use for compressing message sets", COMPRESSION_CODEC_NONE);
+
+const core::Property PublishKafka::QueueBufferMaxTime(
Review comment:
+1.
That's the way linter accepts it as well, so please change as @adamdebreceni
suggest!
##########
File path: extensions/librdkafka/PublishKafka.h
##########
@@ -89,10 +89,10 @@ class PublishKafka : public core::Processor {
static core::Property BatchSize;
static core::Property TargetBatchPayloadSize;
static core::Property AttributeNameRegex;
- static core::Property QueueBufferMaxTime;
- static core::Property QueueBufferMaxSize;
- static core::Property QueueBufferMaxMessage;
- static core::Property CompressCodec;
+ static const core::Property QueueBufferMaxTime;
+ static const core::Property QueueBufferMaxSize;
+ static const core::Property QueueBufferMaxMessage;
+ static const core::Property CompressCodec;
Review comment:
Either all or none pls!
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -82,10 +82,33 @@ core::Property PublishKafka::TargetBatchPayloadSize(
core::PropertyBuilder::createProperty("Target Batch Payload
Size")->withDescription("The target total payload size for a batch. 0 B means
unlimited (Batch Size is still applied).")
->isRequired(false)->withDefaultValue<core::DataSizeValue>("512
KB")->build());
core::Property PublishKafka::AttributeNameRegex("Attributes to Send as
Headers", "Any attribute whose name matches the regex will be added to the
Kafka messages as a Header", "");
-core::Property PublishKafka::QueueBufferMaxTime("Queue Buffering Max Time",
"Delay to wait for messages in the producer queue to accumulate before
constructing message batches", "");
-core::Property PublishKafka::QueueBufferMaxSize("Queue Max Buffer Size",
"Maximum total message size sum allowed on the producer queue", "");
-core::Property PublishKafka::QueueBufferMaxMessage("Queue Max Message",
"Maximum number of messages allowed on the producer queue", "");
-core::Property PublishKafka::CompressCodec("Compress Codec", "compression
codec to use for compressing message sets", COMPRESSION_CODEC_NONE);
+
+const core::Property PublishKafka::QueueBufferMaxTime(
Review comment:
+1.
That's the way linter accepts it as well, so please change as @adamdebreceni
suggest!
Unfortunately this extension is not linted. Yet. :(
##########
File path: extensions/librdkafka/PublishKafka.cpp
##########
@@ -82,10 +82,33 @@ core::Property PublishKafka::TargetBatchPayloadSize(
core::PropertyBuilder::createProperty("Target Batch Payload
Size")->withDescription("The target total payload size for a batch. 0 B means
unlimited (Batch Size is still applied).")
->isRequired(false)->withDefaultValue<core::DataSizeValue>("512
KB")->build());
core::Property PublishKafka::AttributeNameRegex("Attributes to Send as
Headers", "Any attribute whose name matches the regex will be added to the
Kafka messages as a Header", "");
-core::Property PublishKafka::QueueBufferMaxTime("Queue Buffering Max Time",
"Delay to wait for messages in the producer queue to accumulate before
constructing message batches", "");
-core::Property PublishKafka::QueueBufferMaxSize("Queue Max Buffer Size",
"Maximum total message size sum allowed on the producer queue", "");
-core::Property PublishKafka::QueueBufferMaxMessage("Queue Max Message",
"Maximum number of messages allowed on the producer queue", "");
-core::Property PublishKafka::CompressCodec("Compress Codec", "compression
codec to use for compressing message sets", COMPRESSION_CODEC_NONE);
+
+const core::Property PublishKafka::QueueBufferMaxTime(
Review comment:
Not sure if this still applies after your linter changes, but previously
the linter only accepted the "->" operators to be at the begging of the new
line.
If you take a look at standard processors, all use the other format.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
