Woutifier commented on pull request #4233:
URL: https://github.com/apache/nifi/pull/4233#issuecomment-633860926


   > @Woutifier Other than my comment on validating that the time period is > 0 
the code looks good. Is there an easy way to test this (not necessarily a unit 
test)?
   
   Hey @jfrazee thanks for your review. I'll add the >0 check. I'll see if I 
can come up with some way to verify that this actually does something (I did 
test it locally against one of our servers but would be nice to have a small 
test scenario).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to