hunyadi-dev commented on a change in pull request #795:
URL: https://github.com/apache/nifi-minifi-cpp/pull/795#discussion_r431617605
##########
File path: extensions/standard-processors/processors/GetFile.cpp
##########
@@ -146,6 +146,13 @@ void GetFile::onSchedule(core::ProcessContext *context,
core::ProcessSessionFact
if (context->getProperty(FileFilter.getName(), value)) {
request_.fileFilter = value;
}
+
+ if (!context->getProperty(Directory.getName(), value)) {
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Input Directory property is
missing");
+ }
+ if (!utils::file::FileUtils::is_directory(value.c_str())) {
+ throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Input Directory \"" + value +
"\" does not exist");
Review comment:
Minor, but "not a directory" does not imply "does not exist".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
