arpadboda commented on pull request #776: URL: https://github.com/apache/nifi-minifi-cpp/pull/776#issuecomment-637598020
> [#776 (comment)](https://github.com/apache/nifi-minifi-cpp/pull/776#discussion_r431809781) > > As described here, the average producer execution time has increased to 1 second and I think also the heartbeat interval is effectively restricted to at most once a second in absence of other C2 requests, but I didn't test this observation. > > Until this is fixed (or explained why my observation is wrong) I can't +1 this PR. Good point, I agree that we should simply process whatever is there without waiting. The wait_until interface of the concurrentqueue is still useful, so I would keep that, just don't use in the particular case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
