markap14 commented on pull request #4223: URL: https://github.com/apache/nifi/pull/4223#issuecomment-637753053
Thanks @simonbence! I looked over the code and all looks good. Did some tests. The only thing that I think needed to be changed was a minor tweak to FlowFileTable, where it considers which types are numeric for a CHOICE data type. That was due to a commit of mine that was just recently merged in, so it makes sense that it was overlooked. Given that it was just a 1-liner to add the type, I just updated that before pushing the commit. And a big thanks to @tpalfy for reviewing. +1 merged to master. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
