fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435321877
########## File path: libminifi/src/utils/RegexUtils.cpp ########## @@ -158,6 +158,16 @@ const std::vector<std::string>& Regex::getResult() const { return results_; } const std::string& Regex::getSuffix() const { return suffix_; } +bool Regex::matchesFullInput(const std::string ®ex, const std::string &input) { +#ifdef NO_MORE_REGFREEE + std::regex re{regex}; + return std::regex_match(input, re); +#else + Regex rgx('^' + regex + '$'); + return rgx.match(input); +#endif Review comment: `Regex` is still needed, unfortunately, as we still support gcc 4.8, which has a broken `<regex>` implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org