szaszm commented on a change in pull request #805:
URL: https://github.com/apache/nifi-minifi-cpp/pull/805#discussion_r438118065
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -173,8 +173,7 @@ FlowController::~FlowController() {
stop(true);
stopC2();
unload();
- if (NULL != protocol_)
- delete protocol_;
+ protocol_ = nullptr;
Review comment:
I didn't want to risk bugs by changing the order of destruction here.
This class is complex enough that this is a real possibility IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
