hunyadi-dev commented on a change in pull request #809:
URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r439324945
##########
File path: libminifi/src/utils/BackTrace.cpp
##########
@@ -30,22 +30,24 @@
#include <utility>
#endif
+#include <nonstd/optional.hpp>
+
#ifdef HAS_EXECINFO
namespace {
/**
* Demangles a symbol name using the cxx abi.
* @param symbol_name the mangled name of the symbol
* @return the demangled name on success, empty string on failure
*/
- std::string demangle_symbol(const char* symbol_name) {
+ nonstd::optional<std::string> demangle_symbol(const char* symbol_name) {
Review comment:
PoC code change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
