szaszm commented on a change in pull request #809:
URL: https://github.com/apache/nifi-minifi-cpp/pull/809#discussion_r440194759
##########
File path: libminifi/include/utils/OptionalUtils.h
##########
@@ -21,17 +21,20 @@
#include <utility>
#include <nonstd/optional.hpp>
-#include "utils/GeneralUtils.h"
+#include "utils/gsl.h"
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
namespace utils {
+template <typename T>
+using optional = nonstd::optional<T>;
+const nonstd::nullopt_t nullopt = nonstd::nullopt;
Review comment:
As pointed out in the other comment, these could become
using-declarations.
```suggestion
using nonstd::optional;
using nonstd::nullopt;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
