fgerlits commented on a change in pull request #817:
URL: https://github.com/apache/nifi-minifi-cpp/pull/817#discussion_r441356499
##########
File path: libminifi/test/unit/MinifiConcurrentQueueTests.cpp
##########
@@ -31,6 +31,20 @@ namespace utils = org::apache::nifi::minifi::utils;
namespace {
+ template <typename Function, typename Duration>
Review comment:
I was mainly trying to shave off a few characters, but yeah, it's
probably not worth it. I have changed the argument type to
`std::chrono::duration<Rep, Period>` but kept it as pass-by-value, since it is
just a number.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
