alopresto commented on a change in pull request #4344:
URL: https://github.com/apache/nifi/pull/4344#discussion_r441782757



##########
File path: 
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-security/src/main/java/org/apache/nifi/web/security/oidc/OidcService.java
##########
@@ -198,6 +198,7 @@ public void exchangeAuthorizationCode(final String 
oidcRequestIdentifier, final
         }
 
         final CacheKey oidcRequestIdentifierKey = new 
CacheKey(oidcRequestIdentifier);
+        // TODO: Retrieve the authorization code separately from the exchange

Review comment:
       It looks like the internal methods in the identity provider were 
refactored to make this separate, but `exchangeAuthorizationCode` is still the 
only public method, while the others are still private. Maybe translate the 
change to here as well. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to