arpadboda commented on a change in pull request #812:
URL: https://github.com/apache/nifi-minifi-cpp/pull/812#discussion_r442015928



##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -381,23 +405,27 @@ void ConsumeWindowsEventLog::onTrigger(const 
std::shared_ptr<core::ProcessContex
     }
   }
 
+  logger_->log_trace("Finish enumerating events.");

Review comment:
       This can mean that the processor gathered a bunch of events (and those 
events has been generated since the last ontrigger call), so I don't think 
waiting  for a longer time helps in this case.
   Yield might be  considered in case the ontrigger call generated 0 new flow 
files.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to