hunyadi-dev commented on a change in pull request #784:
URL: https://github.com/apache/nifi-minifi-cpp/pull/784#discussion_r444186455
##########
File path: extensions/script/python/ExecutePythonProcessor.h
##########
@@ -18,12 +18,16 @@
* limitations under the License.
*/
-#ifndef NIFI_MINIFI_CPP_EXECUTEPYPROC_H
-#define NIFI_MINIFI_CPP_EXECUTEPYPROC_H
+#ifndef EXTENSIONS_SCRIPT_PYTHON_EXECUTEPYTHONPROCESSOR_H_
+#define EXTENSIONS_SCRIPT_PYTHON_EXECUTEPYTHONPROCESSOR_H_
-#include <concurrentqueue.h>
-#include <core/Resource.h>
-#include <core/Processor.h>
+#include <memory>
+#include <string>
+#include <vector>
+
+#include <concurrentqueue.h> // NOLINT
+#include <core/Resource.h> // NOLINT
Review comment:
I replaced the `<>` with "", but for concurrentqueue, one gets a
different error:
> 28:1 error cpplint Include the directory when naming .h files
[build/include_subdir] [4]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
