tpalfy commented on a change in pull request #4350:
URL: https://github.com/apache/nifi/pull/4350#discussion_r444296917
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutDatabaseRecord.java
##########
@@ -156,7 +162,7 @@
+ "FlowFile. The 'Use statement.type Attribute' option is
the only one that allows the 'SQL' statement type. If 'SQL' is specified, the
value of the field specified by the "
+ "'Field Containing SQL' property is expected to be a
valid SQL statement on the target database, and will be executed as-is.")
Review comment:
I'll add the general info to the description but rather not add the
example because this part of the code has no direct connection to the adapters
so I think it should not comment on _their_ functionality. (The Oracle adapter
- or any other that we might refer in the example - might get updated to
support UPSERT and almost certainly we won't remember to update this doc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
