turcsanyip commented on a change in pull request #4348:
URL: https://github.com/apache/nifi/pull/4348#discussion_r444396485
##########
File path:
nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/reporting/ReportLineageToAtlas.java
##########
@@ -632,10 +667,37 @@ private void setValue(Consumer<String> setter, Runnable
emptyHandler, PropertyVa
}
}
- private void checkAtlasUrls(List<String> urlStrings, ConfigurationContext
context) {
- if (urlStrings.isEmpty()) {
- throw new ProcessException("No Atlas URL has been specified! Set
either the '" + ATLAS_URLS.getDisplayName() + "' " +
- "property on the processor or the 'atlas.rest.address'
porperty in the atlas configuration file.");
+ private void setAtlasSSLConfig(Properties atlasProperties,
ConfigurationContext context, List<String> urls, File confDir) throws
IOException {
+ boolean isAtlasApiSecure = urls.stream().anyMatch(url ->
url.toLowerCase().startsWith("https"));
Review comment:
It is a preexisting line relocated between methods. It is supposed here
that all the URLs have the same scheme so it is enough to check if there is one
https:// (and in this case all the others are https://).
But it was not checked anywhere. Added the check to `customValidate()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
