joewitt commented on pull request #4225: URL: https://github.com/apache/nifi/pull/4225#issuecomment-648445181
I dont quite follow the change to the test class. MOving from an Object[] comparison to any string seems ok but the added isA(flowFile.class) I dont follow. The change in the API from object[] to varargs is probably ok but I am not positive it is binary compatible where one has an older API but a newer client/usage of it. Have we verified that? Lastly the Object[] was likely chosen to be consistent with the API of some logger out there. We might not want to deviate. @markap14 Can you take a look and share your thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
