markobean commented on pull request #4225:
URL: https://github.com/apache/nifi/pull/4225#issuecomment-648511269
The isA(flowFile.class) was in the original code and not added as part of
this PR. It's a mockito thing which I'm not quite following either. The point
of the verify() call in the unit test appears to be to ensure a warning message
was logged. The warning message is issued by the processor in this line:
logger.warn("Trying to parse file without .evtx extension {} from flowfile
{}", new Object[]{basename, flowFile});
The existing update per this PR retaining the "isA(flowFile.class)" does
pass, but might not be doing what is required - or at least not as explicit as
the unit test could be. I think this update to the unit test would be more
appropriate:
verify(componentLog).warn("Trying to parse file without .evtx extension {}
from flowfile {}", basename, flowFile);
If you concur, I'll update the PR code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
