hunyadi-dev commented on a change in pull request #821: URL: https://github.com/apache/nifi-minifi-cpp/pull/821#discussion_r444904692
########## File path: extensions/standard-processors/tests/unit/RetryFlowFileTests.cpp ########## @@ -0,0 +1,221 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#define CATCH_CONFIG_MAIN + +#include <memory> +#include <string> +#include <set> +#include <regex> + +#include "TestBase.h" + +#include "processors/GenerateFlowFile.h" +#include "processors/UpdateAttribute.h" +#include "processors/RetryFlowFile.h" +#include "processors/PutFile.h" +#include "processors/LogAttribute.h" +#include "utils/file/FileUtils.h" +#include "utils/OptionalUtils.h" +#include "utils/TestUtils.h" + +namespace { +using org::apache::nifi::minifi::utils::createTempDir; +using org::apache::nifi::minifi::utils::optional; + +std::vector<std::pair<std::string, std::string>> list_dir_all(const std::string& dir, const std::shared_ptr<logging::Logger>& logger, bool recursive = true) { + return org::apache::nifi::minifi::utils::file::FileUtils::list_dir_all(dir, logger, recursive); +} + +class RetryFlowFileTest { + public: + using Processor = org::apache::nifi::minifi::core::Processor; + using GenerateFlowFile = org::apache::nifi::minifi::processors::GenerateFlowFile; + using UpdateAttribute = org::apache::nifi::minifi::processors::UpdateAttribute; + using RetryFlowFile = org::apache::nifi::minifi::processors::RetryFlowFile; + using PutFile = org::apache::nifi::minifi::processors::PutFile; + using LogAttribute = org::apache::nifi::minifi::processors::LogAttribute; + RetryFlowFileTest() : + logTestController_(LogTestController::getInstance()), + logger_(logging::LoggerFactory<org::apache::nifi::minifi::processors::RetryFlowFile>::getLogger()) { + reInitialize(); + } + virtual ~RetryFlowFileTest() { + logTestController_.reset(); + } + + protected: + void reInitialize() { + testController_.reset(new TestController()); + plan_ = testController_->createPlan(); + logTestController_.setDebug<TestPlan>(); + logTestController_.setDebug<GenerateFlowFile>(); + logTestController_.setDebug<UpdateAttribute>(); + logTestController_.setDebug<RetryFlowFile>(); + logTestController_.setDebug<PutFile>(); + logTestController_.setDebug<PutFile>(); + logTestController_.setDebug<LogAttribute>(); + logTestController_.setDebug<core::ProcessSession>(); + logTestController_.setDebug<core::Connectable>(); + logTestController_.setDebug<minifi::Connection>(); + } + Review comment: Here is a diagram for the test layout: <img width="1120" alt="Screenshot 2020-06-24 at 17 58 27" src="https://user-images.githubusercontent.com/64011968/85590760-f56fd600-b644-11ea-89a9-621e1fbb0a31.png";> - `UpdateAttribute` is used to set the retry attribute and the marker processor uuid - `PutFile` is used to check which outbound relationship was choosen by `RetryFlowFile` - `LogAttribute` is used for checking dynamic properties added on `retries_exceeded` I also have an ASCII art version of the plan, which I can add as a comment if the rules allow it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/64011968/85590760-f56fd600-b644-11ea-89a9-621e1fbb0a31.png"](https://user-images.githubusercontent.com/64011968/85590760-f56fd600-b644-11ea-89a9-621e1fbb0a31.png"){kind=link}