hunyadi-dev commented on a change in pull request #821:
URL: https://github.com/apache/nifi-minifi-cpp/pull/821#discussion_r445451400



##########
File path: libminifi/test/TestBase.cpp
##########
@@ -168,6 +168,30 @@ std::shared_ptr<core::Processor> 
TestPlan::addProcessor(const std::string &proce
   return addProcessor(processor_name, uuid, name, relationships, 
linkToPrevious);
 }
 
+std::shared_ptr<minifi::Connection> TestPlan::addConnection(const 
std::shared_ptr<core::Processor> source_proc, const core::Relationship& 
source_relationship, const std::shared_ptr<core::Processor>& destination_proc) {
+  std::stringstream connection_name;
+  connection_name << source_proc->getUUIDStr() << "-to-" << 
destination_proc->getUUIDStr();

Review comment:
       `TestPlan` does it like this. I would like to refactor this class at 
some point anyway, want me to change the names then?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to