adamdebreceni commented on a change in pull request #797: URL: https://github.com/apache/nifi-minifi-cpp/pull/797#discussion_r445999612
########## File path: libminifi/test/unit/PropertyValidationTests.cpp ########## @@ -0,0 +1,238 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "../TestBase.h" +#include "core/ConfigurableComponent.h" +#include "utils/PropertyErrors.h" +#include "core/PropertyValidation.h" + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace core { + +using namespace utils::internal; +/** + * This Tests checks a deprecated behavior that should be removed + * in the next major release. + */ +TEST_CASE("Some default values get coerced to typed variants") { + auto prop = Property("prop", "d", "true"); + REQUIRE_THROWS_AS(prop.setValue("banana"), ConversionException); + + const std::string SPACE = " "; + auto prop2 = Property("prop", "d", SPACE + "true"); + prop2.setValue("banana"); +} + +TEST_CASE("Converting invalid PropertyValue") { + auto prop = PropertyBuilder::createProperty("prop") + ->withDefaultValue<int>(0) + ->build(); + REQUIRE_THROWS_AS(prop.setValue("not int"), ParseException); + REQUIRE_THROWS_AS(static_cast<int>(prop.getValue()), InvalidValueException); +} + +TEST_CASE("Parsing int has baggage after") { + auto prop = PropertyBuilder::createProperty("prop") + ->withDefaultValue<int>(0) + ->build(); + REQUIRE_THROWS_AS(prop.setValue("55almost int"), ParseException); +} + +TEST_CASE("Parsing int has spaces") { + auto prop = PropertyBuilder::createProperty("prop") + ->withDefaultValue<int>(0) + ->build(); + prop.setValue(" 55 "); + REQUIRE(static_cast<int>(prop.getValue()) == 55); +} + +TEST_CASE("Parsing int out of range") { + auto prop = PropertyBuilder::createProperty("prop") + ->withDefaultValue<int>(0) + ->build(); + REQUIRE_THROWS_AS(prop.setValue(" 5000000000 "), ParseException); Review comment: (not only can it bigger, but it can also be as small as 16 bits) I'll leave this for now as is, if this test fails due to the platform, it should be ease to fix, and also warn us, that we should be more mindful about `int` at other parts of the code I would actually go as far as to remove the `int` (and other non-fixed with integers) as a possible value type, as these are user facing and we can't have a property validation fail on one agent but succeed on an other just because they are running on different platforms ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
