hunyadi-dev commented on a change in pull request #824:
URL: https://github.com/apache/nifi-minifi-cpp/pull/824#discussion_r446232265



##########
File path: 
extensions/openwsman/processors/SourceInitiatedSubscriptionListener.cpp
##########
@@ -159,8 +159,7 @@ 
SourceInitiatedSubscriptionListener::Handler::Handler(SourceInitiatedSubscriptio
 
 SourceInitiatedSubscriptionListener::SubscriberData::SubscriberData()
     : bookmark_(nullptr)
-    , subscription_(nullptr) {
-}
+    , subscription_(nullptr) = default;

Review comment:
       Removed.

##########
File path: libminifi/include/core/state/FlowIdentifier.h
##########
@@ -68,12 +68,7 @@ class FlowIdentifier {
     bucket_id_ = other.bucket_id_;
     flow_id_ = other.flow_id_;
   }
-  FlowIdentifier &operator=(const FlowIdentifier &other) {
-    registry_url_ = other.registry_url_;
-    bucket_id_ = other.bucket_id_;
-    flow_id_ = other.flow_id_;
-    return *this;
-  }
+  FlowIdentifier &operator=(const FlowIdentifier &other) = default;

Review comment:
       As requested.

##########
File path: extensions/windows-event-log/wel/WindowsEventLog.h
##########
@@ -63,8 +63,7 @@ typedef std::vector<std::pair<METADATA, std::string>> 
METADATA_NAMES;
 class WindowsEventLogHandler
 {
 public:
-  WindowsEventLogHandler() : metadata_provider_(nullptr){
-  }
+  WindowsEventLogHandler() : metadata_provider_(nullptr) = default;

Review comment:
       Corrected.

##########
File path: libminifi/include/core/state/UpdatePolicy.h
##########
@@ -122,10 +120,7 @@ class UpdatePolicyBuilder {
 
 
  protected:
-  explicit UpdatePolicyBuilder(const UpdatePolicyBuilder &other)
-      : current_policy_(other.current_policy_) {
-  }
-
+  explicit UpdatePolicyBuilder(const UpdatePolicyBuilder &other) = default;

Review comment:
       Done.

##########
File path: libminifi/include/core/state/UpdatePolicy.h
##########
@@ -69,9 +69,7 @@ class UpdatePolicy {
   }
 
  protected:
-  explicit UpdatePolicy(const UpdatePolicy &other)
-      : enable_all_(other.enable_all_), properties_(other.properties_) {
-  }
+  explicit UpdatePolicy(const UpdatePolicy &other) = default;

Review comment:
       Done.

##########
File path: extensions/opencv/FrameIO.h
##########
@@ -30,7 +30,7 @@ class FrameWriteCallback : public OutputStreamCallback {
     // TODO - Nghia: Check std::move(img_mat).
         : image_mat_(std::move(image_mat)), image_encoding_(image_encoding_) {
     }
-    ~FrameWriteCallback() override = default;
+    ~FrameWriteCallback() = default;

Review comment:
       Restored.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to