fgerlits opened a new pull request #836:
URL: https://github.com/apache/nifi-minifi-cpp/pull/836
Unit tests for the ConsumeWindowsEventLog processor and the related helper
classes Bookmark and MetadataWalker.
Small changes in the classes under test to help unit testing:
* move the unique_evt_handle class from Bookmark.h to its own header, so we
can reuse it,
* refactor MetadataWalker to make the Windows event dependencies mockable.
Coverage is far from perfect. The two main gaps are:
* the processor is not tested in `ProcessOldEvents=true` mode, as this would
read the event log from the start and there is no way (that I know of) to clear
the event log without Administrator rights,
* the Plaintext output format is not tested, only the XML format, as (I
think) one needs to publish manifest-based events for `EvtFormatMessage(...
flags=EvtFormatMessageEvent ...)` to work, and registering a manifest requires
Administrator rights, too.
I have tested these use cases manually, but clearly a unit test would be
better. If you have an idea how to do that, please let me know.
---
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
