[
https://issues.apache.org/jira/browse/OPENNLP-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13679433#comment-13679433
]
Mark Giaconia commented on OPENNLP-579:
---------------------------------------
Thanks for the feedback, I agree that a static method in the factory would be
cleaner... and I will remove the Map of EntityLinkers as well.
As for the EntityLinker - Linkable separation. I did it like this so OpenNLP
gives users the ability to create a series of Linkable sources, and then plug
them into any EntityLinkers they have. Without the Linkable interface the user
would have to "do their own thing" inside an EntityLinker impl (which they
still have the option to do, they can always create their own Linkable series).
Currently if a user creates a Linker, and some Linkables with the interfaces,
they can configure them in the props file and use the BaseEntityLinker abstract
class...which seems quite clean.
I can certainly remove the Linkable interface, I just felt like providing a
sub-framework might be helpful and it provides a logical separation.
Perhaps we could just consider/promote the Linkable as optional, as if it is
essentially the way I personally chose to do my Geo-EntityLinker implementations
I will resubmit the factory in a bit.
> Framework to dynamically link N-best matches from external data to named
> entities by type (EntityLinker framework)
> ------------------------------------------------------------------------------------------------------------------
>
> Key: OPENNLP-579
> URL: https://issues.apache.org/jira/browse/OPENNLP-579
> Project: OpenNLP
> Issue Type: Wish
> Components: Name Finder
> Affects Versions: 1.6.0
> Environment: Any
> Reporter: Mark Giaconia
> Priority: Minor
> Labels: features
> Fix For: 1.6.0
>
> Attachments: EntityLinker_30may2013.zip, entitylinker_8Jun2013.zip,
> entitylinker_9Jun2013.zip, entitylinkerFramework.zip,
> geonamefinder.properties, geonamefind.zip
>
> Original Estimate: 672h
> Remaining Estimate: 672h
>
> A framework for integrating/linking external data to named entities. For
> instance, geocoding or georeferencing location entities to geonames gazateers
> can be implemented as an EntityLinker. Initially created ticket to
> specifically solve the georeferencing problem, but the framework should allow
> linkage of any external data to any entity type. Commercial applications that
> do this are expensive, and there are many free gazateers one could use to
> create solutions with OpenNLP. The capability should provide a default
> implementation using MySQL or Postgres and the USGS/Geonames Gazateers.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
