[ 
https://issues.apache.org/jira/browse/OPENNLP-597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13782861#comment-13782861
 ] 

Joern Kottmann commented on OPENNLP-597:
----------------------------------------

The exception should be passed back to the caller, unluckily the 
Parse.parseParse() methods don't the throw the InvalidFormatException, and we 
can't add it to these methods without breaking backward compatibility.

Therefore I suggest that we implement new parse methods which do the same, but 
have a different name and throw the InvalidFormatException, the old parseParse 
methods can be marked as deprecated, with a reference to the new methods.
At some point it should be possible to then remove the old ones.

> Code in tools/parser throws some NullPointerExceptions when dealing with poor 
> training data
> -------------------------------------------------------------------------------------------
>
>                 Key: OPENNLP-597
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-597
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: tools-1.5.3
>         Environment: Windows 7 + java 1.7.0_21 
>            Reporter: Ioan Barbulescu
>            Priority: Minor
>             Fix For: 1.6.0
>
>         Attachments: Parse.java.patch
>
>
> I was trying to train the Treebank Parser with some new data.
> Truth to be told, the data was in poor format. Specifically, instead of 
> "(-RRB- -RRB-)", it contained "( -RRB-)".
> The same for -LRB- constructions.
> Due to this input data, the parsing code was throwing some 
> NullPointerException errors.
> The fixes consist in some supplementary "if()"s, to safeguard against null 
> pointers.
> Fixes are in 3 files, attached as diff. The diff was created by svn, run in 
> the opennlp-tool/.../parser directory.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to