[
https://issues.apache.org/jira/browse/OPENNLP-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545137#comment-14545137
]
Rodrigo Agerri commented on OPENNLP-775:
----------------------------------------
Hi Peter,
Thanks for the patch. Two comments though:
1. Do we really need the ternary operator here? AFAIK, in this particular case
a traditional if else then would suffice and perhaps be simpler to read by
others (any opinions anyone?).
2. Why there is also in this patch a test about Brat annotations?
> Add support for lowercased word cluster dictionaries
> ----------------------------------------------------
>
> Key: OPENNLP-775
> URL: https://issues.apache.org/jira/browse/OPENNLP-775
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Peter Thygesen
> Attachments: w2v_lowercase_feature.patch
>
>
> Current version will only work with case sensitive dictionaries
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
