[
https://issues.apache.org/jira/browse/OPENNLP-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15364157#comment-15364157
]
ASF GitHub Bot commented on OPENNLP-856:
----------------------------------------
GitHub user jzonthemtn opened a pull request:
https://github.com/apache/opennlp/pull/4
OPENNLP-856: Refactoring AdaptiveFeatureGenerator and
FeatureGeneratorAdapter
Refactoring `AdaptiveFeatureGenerator` and `FeatureGeneratorAdapter` to
only need one (`FeatureGeneratorAdapter`). Setting Java compiler version to 1.8
to support the default functions in `AdaptiveFeatureGenerator` for backward
compatibility.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jzonthemtn/opennlp OPENNLP-856
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 54adcaa84546b3ab0cf00bf78b98ef5e59ea7a1e
Author: jzonthemtn <[email protected]>
Date: 2016-07-05T22:50:58Z
OPENNLP-856: Refactoring AdaptiveFeatureGenerator and
FeatureGeneratorAdapter. Setting Java compiler version to 1.8.
----
> Refactor AdaptiveFeatureGenerator and FeatureGeneratorAdapter
> -------------------------------------------------------------
>
> Key: OPENNLP-856
> URL: https://issues.apache.org/jira/browse/OPENNLP-856
> Project: OpenNLP
> Issue Type: Improvement
> Components: Name Finder
> Affects Versions: 1.6.1
> Reporter: Jeff Zemerick
> Priority: Minor
> Labels: feature, features, generator
>
> Under the package opennlp.tools.util.featuregen there is an interface
> AdaptiveFeatureGenerator and an abstract class FeatureGeneratorAdapter. The
> interface defines the createFeatures(), updateAdaptiveData(), and
> clearAdaptiveData() methods. The abstract class implements this interface to
> provide default implementations of the updateAdaptiveData() and
> clearAdaptiveData() functions. Feature generators then either implement the
> interface or extend the abstract class.
> The purpose of this task is to refactor these classes to remove confusion
> caused by the similarity between the interface and the abstract class. This
> task deprecates the AdaptiveFeatureGenerator interface in favor of the
> abstract class FeatureGeneratorAdapter.
> Default methods will be added to the AdaptiveFeatureGenerator interface to
> maintain backward compatibility. To support the default methods the version
> of the Java compiler will be set to 1.8.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
