[ https://issues.apache.org/jira/browse/OPENNLP-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369960#comment-15369960 ]
ASF GitHub Bot commented on OPENNLP-675: ---------------------------------------- GitHub user jzonthemtn opened a pull request: https://github.com/apache/opennlp/pull/5 OPENNLP-675: Managing logging with log4j Introduces log4j and replaces calls to system.out and system.err (outside of main() functions) with log4j calls. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jzonthemtn/opennlp OPENNLP-675 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/opennlp/pull/5.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5 ---- commit 32e6331b6114eabf921ff75f4df1722f5f3c8b19 Author: jzonthemtn <jeff...@mtnfog.com> Date: 2016-07-09T23:50:09Z Adding log4j as a dependency. commit 5438e8be7a969f99e40a28723654c3b6be04288e Author: jzonthemtn <jeff...@mtnfog.com> Date: 2016-07-10T20:10:32Z OPENNLP-675: Replacing system.out.println in tests with log4j. commit 88347adba4ed3c864c3b943b03fe0815211e8db5 Author: jzonthemtn <jeff...@mtnfog.com> Date: 2016-07-10T21:02:35Z OPENNLP-675: Replacing sys out and sys err with log4j calls. ---- > Absence of logging and usage of System.out > ------------------------------------------ > > Key: OPENNLP-675 > URL: https://issues.apache.org/jira/browse/OPENNLP-675 > Project: OpenNLP > Issue Type: New Feature > Components: Sentence Detector, Tokenizer > Reporter: Eugene Prystupa > > There seems to be no concept of logging used by the libraries. Instead > System.out.println is hard-coded in many places where debug information using > a logging framework would do it. > This makes awkward to use the modules integrated into a different application > (as it spams our logs or console). > Is the usage of System.out in core classes (like GISTrainer) by choice? Or is > it simply a technical debt? I am happy to work on it and provide a patch if > this is a technical debt. -- This message was sent by Atlassian JIRA (v6.3.4#6332)