[
https://issues.apache.org/jira/browse/OPENNLP-880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15767894#comment-15767894
]
Daniel Russ commented on OPENNLP-880:
-------------------------------------
Added a patch that changes multiple items (Sorry That I did not fix 1 item at a
time-I am a scientist not a software engineer):
1.) Added method to EventTrainer -- train(DataIndexer indexer) –Then I
added the method to AbstractEventTrainer. No other code needed to be changed.
2.) Created a new class – PluggableParmeters: Only AbstractTrainers had
access to getXXXParam(Value,Default). So I pulled out this functionality into
a separate class. Now both AbstractTrainers and AbstractDataIndexers can hold
parameters.
3.) Refactored DataIndexer. This touched a lot of code. Added init(Map,Map)
method and index(ObjectStream<Event>) method. Changed 1-Pass and 2-Pass
DataIndexers. Everywhere 1-pass/2-pass indexers where created, I changed the
constructor, and added the init and index methods.
4.) Changed GIS.doTrain(indexer) to use the parameters passed in the init
method.
5.) QNTrainer – created a working init method. Changed the isValid method so
it is not the init method.
#4 Make the GIS class work within the new training API
> Refactor the GIS trainer integration
> ------------------------------------
>
> Key: OPENNLP-880
> URL: https://issues.apache.org/jira/browse/OPENNLP-880
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Joern Kottmann
> Priority: Minor
> Attachments: patch.txt
>
>
> The GIS code was never reshaped to fit properly into the new Training API.
> There are a couple of issues e.g. not using parameters which should be fixed.
> TODO: Update this description and list the changes
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
