[
https://issues.apache.org/jira/browse/OPENNLP-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15793837#comment-15793837
]
ASF GitHub Bot commented on OPENNLP-274:
----------------------------------------
GitHub user wcolen opened a pull request:
https://github.com/apache/opennlp/pull/26
OPENNLP-274: Adds cache to Chunker
Adds cache to Chunker. Tested and it causes no regression.
Also tested if there is any improvement adding the cache, but did not
notice. Comparing Chunker CV in 1.7.0 and 1.7.1-SNAPSHOT witch cache 3 and
1000, there was no relevant improvement in speed.
See issue OPENNLP-274
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcolen/opennlp 274
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 22955b5b2368b17aab97d032024f2c5e4f55c625
Author: William D C M SILVA <[email protected]>
Date: 2017-01-03T01:18:11Z
Adds cache to Chunker
See issue OPENNLP-274
----
> Chunker feature generation should use caching like the POS Tagger or Name
> Finder
> --------------------------------------------------------------------------------
>
> Key: OPENNLP-274
> URL: https://issues.apache.org/jira/browse/OPENNLP-274
> Project: OpenNLP
> Issue Type: Improvement
> Components: Chunker
> Reporter: Joern Kottmann
> Assignee: William Colen
> Priority: Minor
> Fix For: 1.7.1
>
>
> The chunker feature generation is currently not cached. The caching should be
> implemented in the same fashion as it is done for the POS Tagger or Name
> Finder.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)