[
https://issues.apache.org/jira/browse/OPENNLP-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15818053#comment-15818053
]
ASF GitHub Bot commented on OPENNLP-719:
----------------------------------------
GitHub user wcolen opened a pull request:
https://github.com/apache/opennlp/pull/48
OPENNLP-719: changes NameFinder type to override any annotation
The previous PR was only overriding if the span type was null, now it
override if the parameter is set.
See OPENNLP-719
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcolen/opennlp 719b
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 7e0f11deddde302376769a8293541e819c1fcc88
Author: William D C M SILVA <[email protected]>
Date: 2017-01-11T11:20:38Z
OPENNLP-719: changes NameFinderEventStream type to override any annotation
The previous PR was only overriding if the span type was null, now it
override if the parameter is set.
See OPENNLP-719
----
> Type argument does not override the samples
> -------------------------------------------
>
> Key: OPENNLP-719
> URL: https://issues.apache.org/jira/browse/OPENNLP-719
> Project: OpenNLP
> Issue Type: Bug
> Components: Name Finder
> Affects Versions: tools-1.5.3, 1.6.0
> Reporter: Gustavo Knuppe
> Assignee: William Colen
> Fix For: 1.7.1
>
>
> The argument "type" in the class NameFinderEventStream should override the
> type of the samples. It seems that this parameter has no use at the moment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
