[
https://issues.apache.org/jira/browse/OPENNLP-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895583#comment-15895583
]
ASF GitHub Bot commented on OPENNLP-985:
----------------------------------------
GitHub user kinow opened a pull request:
https://github.com/apache/opennlp-sandbox/pull/1
OPENNLP-985: fix an if statement that always returned true.
Fix for [OPENNLP-985](https://issues.apache.org/jira/browse/OPENNLP-985).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/opennlp-sandbox fix-OPENNLP-985
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp-sandbox/pull/1.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1
----
commit a457e62f986c96c7202c49f037df71fec2ef1d43
Author: Bruno P. Kinoshita <[email protected]>
Date: 2017-03-04T08:19:21Z
OPENNLP-985: fix an if statement that always returned true.
----
> A condition that is always true.
> --------------------------------
>
> Key: OPENNLP-985
> URL: https://issues.apache.org/jira/browse/OPENNLP-985
> Project: OpenNLP
> Issue Type: Bug
> Components: wsd
> Reporter: JC
> Priority: Trivial
>
> I've found a code smell or typo in a recent github snapshot. (opennlp-snadbox)
> Path:
> opennlp-wsd/src/main/java/opennlp/tools/disambiguator/datareader/Paragraph.java
> {code:java}
> 85 public boolean contains(String wordTag) {
> 86
> 87 for (Sentence isentence : this.getSsentences()) {
> 88 for (Word iword : isentence.getIwords()) {
> 89 if (iword.equals(iword))
> 90 return true;
> 91 }
> 92 }
> 93
> 94 return false;
> 95 }
> {code}
> Line 89 is always true. This might be a trivial issue but wanted to report
> just in case. Thanks!
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
