[
https://issues.apache.org/jira/browse/OPENNLP-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15945333#comment-15945333
]
ASF GitHub Bot commented on OPENNLP-1006:
-----------------------------------------
GitHub user thygesen opened a pull request:
https://github.com/apache/opennlp/pull/148
OPENNLP-1006: Refactor usage of tag constants in sequence validators
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [√] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [√] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [√] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [√] Is your initial contribution a single, squashed commit?
### For code changes:
- [√] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [n/a] Have you written or updated unit tests to verify your changes?
- [n/a] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [n/a] If applicable, have you updated the LICENSE file, including the
main LICENSE file in opennlp folder?
- [n/a] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [n/a] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
### Impl. Notes:
Not possible to correct:
Deprecated method generateOutcomes in NameFinderEventStream class.
getContext method in DefaultNameContextGenerator because it is unclear
which Codec uses this class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/thygesen/opennlp opennlp-1006
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/148.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #148
----
commit dd0e502eaff402bdb9692f2b44de68e474f3ce95
Author: Peter Thygesen <[email protected]>
Date: 2017-03-28T14:59:34Z
OPENNLP-1006: Refactor usage of tag constants in sequence validators
----
> Refactor usage of tag constants in sequence validators
> ------------------------------------------------------
>
> Key: OPENNLP-1006
> URL: https://issues.apache.org/jira/browse/OPENNLP-1006
> Project: OpenNLP
> Issue Type: Improvement
> Components: Name Finder
> Reporter: Peter Thygesen
> Assignee: Peter Thygesen
> Priority: Minor
>
> NameFinderME tags should not be used in the codec classes. Use the codecs own
> tags.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
