[
https://issues.apache.org/jira/browse/OPENNLP-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968842#comment-15968842
]
ASF GitHub Bot commented on OPENNLP-1019:
-----------------------------------------
GitHub user kottmann opened a pull request:
https://github.com/apache/opennlp/pull/155
OPENNLP-1019: Fix assert statement
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kottmann/opennlp opennlp-1019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/opennlp/pull/155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #155
----
commit 6bfab6c117ac22f3d3d68669af7d38b3717c7f5f
Author: Kottmann <[email protected]>
Date: 2017-04-14T09:12:15Z
OPENNLP-1019: Fix assert statement
----
> Parser Eval Test is not correctly checking the result
> -----------------------------------------------------
>
> Key: OPENNLP-1019
> URL: https://issues.apache.org/jira/browse/OPENNLP-1019
> Project: OpenNLP
> Issue Type: Bug
> Components: Build, Packaging and Test, Parser
> Reporter: Joern Kottmann
> Assignee: Joern Kottmann
> Priority: Minor
> Fix For: 1.8.0
>
>
> The parser eval test is not using Assert.assertEquals correctly to test the
> result.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
