[ 
https://issues.apache.org/jira/browse/OPENNLP-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15976233#comment-15976233
 ] 

Koji Sekiguchi commented on OPENNLP-1036:
-----------------------------------------

In this PR, to guarantee back-compat, I marked getSettings() which returns 
Map<String,String> as deprecated and added getObjectSettings which returns 
Map<String,Object>. And I added throws annotation to getXxxParameter because 
they no longer throw NumberFormatException but throw ClassCastException.

> Use Object values in TrainingParameters instead of String
> ---------------------------------------------------------
>
>                 Key: OPENNLP-1036
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1036
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Chunker, Doccat, Lemmatizer, Name Finder, POS Tagger, 
> Sentence Detector, Tokenizer
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>
> When I worked on OPENNLP-1032, I realized that TrainingParameters manages 
> parameters as Map<String,String>. So, users have to set their int parameters 
> like this:
> {code}
> trainParam.put("name", "100");
> {code}
> but it should look like this:
> {code}
> trainParam.put("name", 100);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to