[
https://issues.apache.org/jira/browse/OPENNLP-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215218#comment-16215218
]
ASF GitHub Bot commented on OPENNLP-1149:
-----------------------------------------
danielruss commented on a change in pull request #280: OPENNLP-1149: remove
unused member in PlainTextByLineStream and chang…
URL: https://github.com/apache/opennlp/pull/280#discussion_r146285479
##########
File path:
opennlp-tools/src/main/java/opennlp/tools/util/PlainTextByLineStream.java
##########
@@ -59,19 +55,12 @@ public void reset() throws IOException {
if (inputStreamFactory != null) {
Review comment:
I think the original idea of this check was to select between various ways
of passing the datasource (File/Inputstream) into the class. Now that we pass
in the factory, I don't think we need to worry about this. Unless, the user
passes in a null factory. In that case, it is appropriate to throw a
NullPointerException.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> remove unused member in PlainTextByLineStream
> ---------------------------------------------
>
> Key: OPENNLP-1149
> URL: https://issues.apache.org/jira/browse/OPENNLP-1149
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 1.8.2
> Reporter: Koji Sekiguchi
> Priority: Trivial
> Fix For: 1.8.3
>
>
> PlainTextByLineStream has a private member variable "channel" but it is never
> set and hence, it is always null. It can be removed to simplify code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
