[jira] [Commented] (OPENNLP-1159) avoid letting users specify AggregatedFeatureGeneratorFactory in XML config

[Koji Sekiguchi (JIRA)]

    [ 
https://issues.apache.org/jira/browse/OPENNLP-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269969#comment-16269969
 ] 

Koji Sekiguchi commented on OPENNLP-1159:
-----------------------------------------

After committing OPENNLP-1154, the XML config looks like:

{code:xml}
<featureGenerators name="nameFinder">
  <generator 
class="opennlp.tools.util.featuregen.AggregatedFeatureGeneratorFactory">
    <generator 
class="opennlp.tools.util.featuregen.CachedFeatureGeneratorFactory">
      <generator 
class="opennlp.tools.util.featuregen.AggregatedFeatureGeneratorFactory">
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenClassFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.DefinitionFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.PreviousMapFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.BigramNameFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.SentenceFeatureGeneratorFactory">
          <bool name="begin">true</bool>
          <bool name="end">false</bool>
        </generator>
      </generator>
    </generator>
  </generator>
</featureGenerators>
{code}

Then after committing this ticket, the XML config looks like:

{code:xml}
<featureGenerators name="nameFinder">
    <generator 
class="opennlp.tools.util.featuregen.CachedFeatureGeneratorFactory">
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenClassFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.WindowFeatureGeneratorFactory">
          <int name="prevLength">2</int>
          <int name="nextLength">2</int>
          <generator 
class="opennlp.tools.util.featuregen.TokenFeatureGeneratorFactory"/>
        </generator>
        <generator 
class="opennlp.tools.util.featuregen.DefinitionFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.PreviousMapFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.BigramNameFeatureGeneratorFactory"/>
        <generator 
class="opennlp.tools.util.featuregen.SentenceFeatureGeneratorFactory">
          <bool name="begin">true</bool>
          <bool name="end">false</bool>
        </generator>
    </generator>
</featureGenerators>
{code}

CachedFeatureGeneratorFactory should be avoided letting users specify 
explicitly but I prefer to implement it in OPENNLP-1160.

> avoid letting users specify AggregatedFeatureGeneratorFactory in XML config
> ---------------------------------------------------------------------------
>
>                 Key: OPENNLP-1159
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1159
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Formats, Name Finder
>    Affects Versions: 1.8.3
>            Reporter: Koji Sekiguchi
>            Assignee: Koji Sekiguchi
>            Priority: Minor
>
> When I'm working on OPENNLP-1154, I think we should do it for better use.
> I'd like to implement this as an independent ticket from OPENNLP-1154 to make 
> patch easy to read.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)