[
https://issues.apache.org/jira/browse/OPENNLP-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16291876#comment-16291876
]
ASF GitHub Bot commented on OPENNLP-1167:
-----------------------------------------
kojisekig commented on issue #295: OPENNLP-1167 - Remove WV#toDouble/FloatArray
URL: https://github.com/apache/opennlp/pull/295#issuecomment-351885403
+1 lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> WordVector toArray methods should be removed
> --------------------------------------------
>
> Key: OPENNLP-1167
> URL: https://issues.apache.org/jira/browse/OPENNLP-1167
> Project: OpenNLP
> Issue Type: Task
> Components: word vectors
> Reporter: Tommaso Teofili
> Assignee: Tommaso Teofili
>
> {{WordVector#toDoubleArray}} and {{WordVector#toFloatArray}} always require a
> copy, have size limitation and therefore should be probably removed.
> Additionally we should think whether it makes sense to keep
> {{FloatArrayVector#toDoubleBuffer}} and {{DoubleArrayVector#toFloatBuffer}}
> which also require a copy. The alternative is to throw an
> {{UnsupportedOperationException}} in such cases.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
