[
https://issues.apache.org/jira/browse/OPENNLP-1168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16298210#comment-16298210
]
ASF GitHub Bot commented on OPENNLP-1168:
-----------------------------------------
kottmann commented on a change in pull request #296: OPENNLP-1168: Resolved
concurrency issue in POS tagger.
URL: https://github.com/apache/opennlp/pull/296#discussion_r157981899
##########
File path: opennlp-tools/src/main/java/opennlp/tools/postag/POSTaggerME.java
##########
@@ -222,8 +222,8 @@ public void probs(double[] probs) {
}
public static POSModel train(String languageCode,
- ObjectStream<POSSample> samples, TrainingParameters trainParams,
- POSTaggerFactory posFactory) throws IOException {
+ ObjectStream<POSSample> samples,
TrainingParameters trainParams,
Review comment:
These minor formatting changes should be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Resolved concurrency issue in POS tagger.
> -----------------------------------------
>
> Key: OPENNLP-1168
> URL: https://issues.apache.org/jira/browse/OPENNLP-1168
> Project: OpenNLP
> Issue Type: Improvement
> Components: POS Tagger
> Affects Versions: 1.8.4
> Reporter: Niels Schuette
> Labels: easyfix, patch
> Fix For: 1.8.4
>
>
> We encountered a concurrency issue in the pos tagger module in the class
> DefaultPOSContextGenerator.
> The issue is demonstrated in DefaultPOSContextGeneratorTest.java. The test
> "multithreading()" consistently fails on our system with the current code if
> the number of threads (NUMBER_OF_THREADS) is set to 10. If the number of
> threads is set to 1 (effectively disabling multithreading), the test
> consistently passes.
> We resolved the issue by removing a field in DefaultPOSContextGenerator.java.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
