[
https://issues.apache.org/jira/browse/OPENNLP-1193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437250#comment-16437250
]
ASF GitHub Bot commented on OPENNLP-1193:
-----------------------------------------
kottmann commented on a change in pull request #311: OPENNLP-1193 Add support
for multi fragment annotatiosn
URL: https://github.com/apache/opennlp/pull/311#discussion_r181372212
##########
File path:
opennlp-tools/src/main/java/opennlp/tools/formats/brat/BratDocumentParser.java
##########
@@ -112,23 +114,42 @@ public BratDocumentParser(SentenceDetector
sentenceDetector, Tokenizer tokenizer
if (ann instanceof SpanAnnotation) {
SpanAnnotation entity = (SpanAnnotation) ann;
- Span entitySpan = entity.getSpan();
+ // TODO: create a list of token spans
Review comment:
Would be good to have a test for this here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Brat format support fails on multi fragment annotations
> -------------------------------------------------------
>
> Key: OPENNLP-1193
> URL: https://issues.apache.org/jira/browse/OPENNLP-1193
> Project: OpenNLP
> Issue Type: Bug
> Components: Formats, Name Finder
> Affects Versions: 1.8.4
> Reporter: Joern Kottmann
> Assignee: Joern Kottmann
> Priority: Major
> Fix For: 1.8.5
>
>
> The brat format support assumes that annotation with multiple fragments are
> always appear next to each other, this assumption is false (and is only true
> if there is a line break). If a single annotation is composed of multiple
> fragments they should be outputted as multiple name spans as well.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
