[
https://issues.apache.org/jira/browse/OPENNLP-1195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16474086#comment-16474086
]
ASF GitHub Bot commented on OPENNLP-1195:
-----------------------------------------
kottmann commented on issue #313: OPENNLP-1195: move maxIndex method to
AbstractEventTrainer
URL: https://github.com/apache/opennlp/pull/313#issuecomment-388793837
There are more usages of argmax in the OpenNLP source code.
I propose we create one common method and then try to only use that one.
We could move the ArrayMath to a more general package and place a common
method there, or keep the existing one:
https://github.com/apache/opennlp/blob/master/opennlp-tools/src/main/java/opennlp/tools/ml/maxent/quasinewton/ArrayMath.java#L90
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> move maxIndex method to AbstractEventTrainer
> --------------------------------------------
>
> Key: OPENNLP-1195
> URL: https://issues.apache.org/jira/browse/OPENNLP-1195
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 1.8.4
> Reporter: Koji Sekiguchi
> Priority: Trivial
>
> PerceptronTrainer and NaiveBayesTrainer have their own private maxIndex()
> method and they are identical.
> Why don't we move it to their parent class?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
