[ 
https://issues.apache.org/jira/browse/OPENNLP-1197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480112#comment-16480112
 ] 

ASF GitHub Bot commented on OPENNLP-1197:
-----------------------------------------

kojisekig opened a new pull request #316: OPENNLP-1197: support Japanese 
letters in FeatureGeneratorUtil
URL: https://github.com/apache/opennlp/pull/316
 
 
   Thank you for contributing to Apache OpenNLP.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [ ] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [ ] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> FeatureGeneratorUtil.tokenFeature() always returns "lc" for Japanese words
> --------------------------------------------------------------------------
>
>                 Key: OPENNLP-1197
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1197
>             Project: OpenNLP
>          Issue Type: Bug
>          Components: Machine Learning
>    Affects Versions: 1.8.4
>            Reporter: Koji Sekiguchi
>            Priority: Major
>
> FeatureGeneratorUtil.tokenFeature() always recognizes Japanese words as "lc" 
> (lower case). It looks a bug to me because they're not lower case letters, 
> but other than that, it seems that FeatureGeneratorUtil.tokenFeature() takes 
> care only Europe/American languages.
> For example, in Japanese NER problem, typical token classes are as follows:
> - DIGIT
> - HIRA : あ, い, う, え, お etc.
> - KATA : ア, イ, ウ, エ, オ etc.
> - ALPHA : we don't need to distinguish lower/upper case
> - OTHER
> I think it's possible that we get FeatureGeneratorUtil.tokenFeature() to have 
> additional token classes I mentioned above, but later on, someone who comes 
> from Asia and may claim similar thing.
> I'd like to make FeatureGeneratorUtil plugable, but I don't have any idea now.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to