[
https://issues.apache.org/jira/browse/OPENNLP-1213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16579723#comment-16579723
]
ASF GitHub Bot commented on OPENNLP-1213:
-----------------------------------------
kottmann commented on a change in pull request #328: OPENNLP-1213: Use ja for
Japanese language code rather than jp
URL: https://github.com/apache/opennlp/pull/328#discussion_r209928557
##########
File path:
opennlp-tools/src/main/java/opennlp/tools/sentdetect/lang/Factory.java
##########
@@ -35,7 +35,7 @@
public static final char[] thEosCharacters = new char[] { ' ','\n' };
- public static final char[] jpEosCharacters = new char[] {'。', '！', '？'};
+ public static final char[] jaEosCharacters = new char[] {'。', '！', '？'};
Review comment:
Would be better to use the three letter codes in the variable name. It was
decided to drop two letter codes from OpenNLP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use ja for Japanese language code rather than jp
> ------------------------------------------------
>
> Key: OPENNLP-1213
> URL: https://issues.apache.org/jira/browse/OPENNLP-1213
> Project: OpenNLP
> Issue Type: Bug
> Affects Versions: 1.9.0
> Reporter: Koji Sekiguchi
> Priority: Minor
> Fix For: 1.9.1
>
>
> It seems that Factory of sentdetect uses "jp" for Japanese language code but
> I think it is country code. Let's use "ja" instead.
> We could leave "jp" for back-compat, but I don't think we need to do it. So
> I'll just replace "jp" with "ja" in the patch.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
