[
https://issues.apache.org/jira/browse/OPENNLP-1224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16675042#comment-16675042
]
ASF GitHub Bot commented on OPENNLP-1224:
-----------------------------------------
eddspencer opened a new pull request #338: OPENNLP-1224 Daemon threads
URL: https://github.com/apache/opennlp/pull/338
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Use Daemon threads in executor services
> ---------------------------------------
>
> Key: OPENNLP-1224
> URL: https://issues.apache.org/jira/browse/OPENNLP-1224
> Project: OpenNLP
> Issue Type: Improvement
> Reporter: Edd Spencer
> Priority: Major
>
> For all executor services it would be ideal if they are configured to use
> daemon threads. This will mean that should the process need to be shutdown it
> will not wait until these threads are complete in order to do so (which can
> take a long time depending on operation).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
