[
https://issues.apache.org/jira/browse/OPENNLP-1264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850836#comment-16850836
]
ASF GitHub Bot commented on OPENNLP-1264:
-----------------------------------------
kottmann commented on pull request #354: OPENNLP-1264 Fix checkstyle
NewlineAtEndOfFile for unix
URL: https://github.com/apache/opennlp/pull/354
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Trivial fixes to enable building on, gasp, Windows
> --------------------------------------------------
>
> Key: OPENNLP-1264
> URL: https://issues.apache.org/jira/browse/OPENNLP-1264
> Project: OpenNLP
> Issue Type: Task
> Reporter: Tim Allison
> Priority: Trivial
>
> I had to change 3 things to get a clean build on Windows...I'm not sure the
> solutions are the most elegant, and these may be user error
> 1) I had to turn off (fail on error) in style checking because of a problem w
> new lines. On nearly every file, I got this failure.
> {noformat}
> [ERROR] src\test\java\opennlp\tools\util\VersionTest.java:[0] (misc)
> NewlineAtEndOfFile: File does not end with a newline.
> [WARNING] checkstyle:check violations detected but failOnViolation set to
> false
> {noformat}
> 2) {{LanguageDetectorEvaluatorTest#processSample}} fails because '\n' are
> expected, but Windows, of course, writes '\r\n' with {{println}}
> 3) I intentionally have a space in the directory structure to my IdeaProjects
> directory, which can cause problems on Windows when finding paths. There are
> two areas where this happens.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
