[ 
https://issues.apache.org/jira/browse/OPENNLP-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17199746#comment-17199746
 ] 

ASF GitHub Bot commented on OPENNLP-1308:
-----------------------------------------

MikalaiD opened a new pull request #378:
URL: https://github.com/apache/opennlp/pull/378


   Corrected code snippet
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
        in the commit message?
   
   - [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA 
number you are trying to resolve? Pay particular attention to the hyphen "-" 
character.
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically master)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] Have you ensured that the full suite of tests is executed via mvn 
clean install at the root opennlp folder?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
   - [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file in opennlp folder?
   - [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found in opennlp folder?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which 
it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Incorrect code snippet in Name Finder Training -> Training Api
> --------------------------------------------------------------
>
>                 Key: OPENNLP-1308
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1308
>             Project: OpenNLP
>          Issue Type: Documentation
>            Reporter: Mikalai Dudko
>            Priority: Trivial
>
> Manual -> Name Finder Training -> Training Api section -> 
> TokenNameFinderFactory and modelOut
> {code:java}
> ObjectStream<String> lineStream =
>               new PlainTextByLineStream(new 
> FileInputStream("en-ner-person.train"), StandardCharsets.UTF_8);
> TokenNameFinderModel model;
> try (ObjectStream<NameSample> sampleStream = new 
> NameSampleDataStream(lineStream)) {
>   model = NameFinderME.train("en", "person", sampleStream, 
> TrainingParameters.defaultParams(),
>             TokenNameFinderFactory nameFinderFactory);
> }
> try (modelOut = new BufferedOutputStream(new FileOutputStream(modelFile)){
>   model.serialize(modelOut);
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to