[ 
https://issues.apache.org/jira/browse/OPENNLP-1318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243505#comment-17243505
 ] 

ASF GitHub Bot commented on OPENNLP-1318:
-----------------------------------------

kinow commented on a change in pull request #383:
URL: https://github.com/apache/opennlp/pull/383#discussion_r535591013



##########
File path: 
opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java
##########
@@ -109,6 +110,21 @@ public void testNameFinder() throws Exception {
     Assert.assertEquals(new Span(4, 6, DEFAULT), names[1]);
   }
 
+  @Test
+  public void testNameFinderWithDownloadedModel() throws Exception {
+
+    String input = "Pierre Vinken , 61 years old , will join the board as a 
nonexecutive director Nov. 29 .";
+    String[] sentence = input.split(" ");
+
+    TokenNameFinder nameFinder = new NameFinderME("en", 
DownloadUtil.EntityType.PERSON);

Review comment:
       Good idea, or group them so that if one starts failing we can disable 
temporarily until whatever issue is fixed and they can be re-enabled.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


> Add ability to download models from within OpenNLP
> --------------------------------------------------
>
>                 Key: OPENNLP-1318
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1318
>             Project: OpenNLP
>          Issue Type: Task
>            Reporter: Jeffrey T. Zemerick
>            Assignee: Jeffrey T. Zemerick
>            Priority: Major
>
> Add ability to download models from within OpenNLP.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to