[
https://issues.apache.org/jira/browse/OPENNLP-1361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626038#comment-17626038
]
ASF GitHub Bot commented on OPENNLP-1361:
-----------------------------------------
rzo1 opened a new pull request, #431:
URL: https://github.com/apache/opennlp/pull/431
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x]} Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
------------------------
# What does this PR do?
This PR migrates the current JUnit 4 tests towards JUnit 5.
To do so, I conducted the following steps:
- Automatically convert JUnit 4 via
https://github.com/junit-pioneer/convert-junit4-to-junit5 (sadly, it doesn't
guarantee formatting)
- Format the converted classes according to the OpenNLP style guide via the
provided IntelliJ Formatter rules.
- Manually adjust test cases, in which an automatic conversion wasn't
possible due to method signature ambiquity (mostly eps/delta for float/double
comparisions, String comparisions with messages).
- Replacement of `@TemporaryFolder` rules with `@TempDir` and related
compensation code.
After the conversion I run a `mvn clean install -Pjacoco`:
```bash
[INFO] Scanning for projects...
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Build Order:
[INFO]
[INFO] Apache OpenNLP Reactor
[INFO] Apache OpenNLP Tools
[INFO] Apache OpenNLP UIMA Annotators
[INFO] Apache OpenNLP Brat Annotator
[INFO] Apache OpenNLP Morfologik Addon
[INFO] Apache OpenNLP Documentation
[INFO] Apache OpenNLP Distribution
[INFO] opennlp-dl
[INFO]
[INFO]
------------------------------------------------------------------------
[INFO] Building Apache OpenNLP Reactor 2.0.1-SNAPSHOT
[INFO]
------------------------------------------------------------------------
...
[INFO] -
> Upgrade JUnit to version 5
> --------------------------
>
> Key: OPENNLP-1361
> URL: https://issues.apache.org/jira/browse/OPENNLP-1361
> Project: OpenNLP
> Issue Type: Task
> Components: Build, Packaging and Test
> Reporter: Jeff Zemerick
> Priority: Minor
>
> Upgrade JUnit to version 5.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
