[
https://issues.apache.org/jira/browse/OPENNLP-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626255#comment-17626255
]
ASF GitHub Bot commented on OPENNLP-1394:
-----------------------------------------
mawiesne opened a new pull request, #432:
URL: https://github.com/apache/opennlp/pull/432
Summary:
-
- eliminates several compiler warnings by more consequent use of generic
types
- reduces use of deprecated api calls to external deps
- introduces Sample interface as a marker for similar impl classes
- introduces Trainer interface as a marker for similar impl classes
- adapts previously deprecated methods in AbstractTrainer
- removes deprecated constructor 'TrainingParameters(Map<String,String>
map)' in favor of 'public TrainingParameters(Map<String,Object> map)'
- removes deprecated methods in TrainingParameters
Tasks
-
Thank you for contributing to Apache OpenNLP.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn
clean install at the root opennlp folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file in opennlp folder?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found in opennlp folder?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions for
build issues and submit an update to your PR as soon as possible.
> Reduce compiler warnings during build
> -------------------------------------
>
> Key: OPENNLP-1394
> URL: https://issues.apache.org/jira/browse/OPENNLP-1394
> Project: OpenNLP
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Environment: All
> Reporter: Martin Wiesner
> Priority: Minor
>
> While working on OPENNLP-1366, I noticed a significant amount of _javac_
> warnings due to switch to Java-11, such as unchecked variable assignments,
> unclear types. Furthermore several deprecation warnings arose during build.
>
> Goal:
> Reduce the amount of compiler warnings to a minimum.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
