[
https://issues.apache.org/jira/browse/OPENNLP-1176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627231#comment-17627231
]
Martin Wiesner commented on OPENNLP-1176:
-----------------------------------------
This issue is no longer relevant as the code was modified as proposed by
[~pramahap] on May 22nd, 2018.
[~jzemerick] Could you mark this issue as resolved / fixed ? The precise fix
version, however, is unclear to me..
> opennlp.tools.ngram.NGramGenerator.java
> ----------------------------------------
>
> Key: OPENNLP-1176
> URL: https://issues.apache.org/jira/browse/OPENNLP-1176
> Project: OpenNLP
> Issue Type: Question
> Reporter: Prachi Prakash
> Priority: Trivial
>
> Hello All,
> I am new to opennlp and was looking to NGramGenerator.java where I found this
> piece of code which creates a list of n-grams from a list of words or
> characters.
> for (int i = 0; i < input.size() - (n - 2); i++) {
> final StringBuilder sb = new StringBuilder();
> if ((i + n) <= input.size()) {
> for (int x = i; x < (n + i); x++) {
> sb.append(input.get(x));
> sb.append(separator);
> }
> String gram = sb.toString();
> gram = gram.substring(0, gram.lastIndexOf(separator));
> outGrams.add(gram);
> }
> }
> which can be modified to
> for (int i = 0; i < input.size() - (n - 1); i++) {
> final StringBuilder sb = new StringBuilder();
>
> for (int x = i; x < (n + i); x++) {
> sb.append(input.get(x));
> sb.append(separator);
> }
> String gram = sb.toString();
> gram = gram.substring(0, gram.lastIndexOf(separator));
> outGrams.add(gram);
>
> }
> which will save some comparison can anyone please guide this is not being
> done.
> Thanks,
> Prachi Prakash
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
